Revert "Skip update checks for bundled packages" #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeeDeeG
approved these changes
Sep 17, 2023
There was a problem hiding this comment.
Approve, reasoning was laid out more fully in a comment on the original PR: #91 (comment)
Thanks for getting to this! And for the overall efforts to address unneeded backend API usage in Pulsar / ppm. 👍
Aaaaand... It's neat that the "Revert" button works! Could be convenient in the future, possibly maybe. Who knows??
|
Approved, tests pass, this is a pretty simple revert PR, we can merge it IMO. Merging! Thanks again. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #91
We have discovered later on that this change doesn't actually need to happen.
Basically while the code is solid, the location packages are checked from to then check them for updates, would never include any actual bundled packages. Since those are all wrapped up in an asar, rather than the users
.packagesdirectory.So lets go ahead and revert it, to avoid complexity for complexities sake.